From f3ec395e37067bfd8b5d854feaf9fce5db6cb3f3 Mon Sep 17 00:00:00 2001 From: Jonas Kaninda Date: Mon, 21 Oct 2024 08:22:06 +0200 Subject: [PATCH] refactor: clean up code --- pkg/backup.go | 10 +++++----- pkg/helper.go | 6 +++--- pkg/restore.go | 4 ++-- pkg/s3.go | 9 ++++++--- utils/logger.go | 9 --------- 5 files changed, 16 insertions(+), 22 deletions(-) diff --git a/pkg/backup.go b/pkg/backup.go index 05f9b0d..3284456 100644 --- a/pkg/backup.go +++ b/pkg/backup.go @@ -195,7 +195,7 @@ func BackupDatabase(db *dbConfig, backupFileName string, disableCompression bool if err != nil { log.Fatal(err) } - utils.Done("Database has been backed up") + utils.Info("Database has been backed up") } else { // Execute mysqldump @@ -217,7 +217,7 @@ func BackupDatabase(db *dbConfig, backupFileName string, disableCompression bool if err := gzipCmd.Wait(); err != nil { log.Fatal(err) } - utils.Done("Database has been backed up") + utils.Info("Database has been backed up") } @@ -301,7 +301,7 @@ func s3Backup(db *dbConfig, config *BackupConfig) { utils.Fatal("Error deleting old backup from S3: %s ", err) } } - utils.Done("Uploading backup archive to remote storage S3 ... done ") + utils.Info("Uploading backup archive to remote storage S3 ... done ") //Send notification utils.NotifySuccess(&utils.NotificationData{ File: finalFileName, @@ -353,7 +353,7 @@ func sshBackup(db *dbConfig, config *BackupConfig) { } - utils.Done("Uploading backup archive to remote storage ... done ") + utils.Info("Uploading backup archive to remote storage ... done ") //Send notification utils.NotifySuccess(&utils.NotificationData{ File: finalFileName, @@ -405,7 +405,7 @@ func ftpBackup(db *dbConfig, config *BackupConfig) { } - utils.Done("Uploading backup archive to the remote FTP server ... done ") + utils.Info("Uploading backup archive to the remote FTP server ... done ") //Send notification utils.NotifySuccess(&utils.NotificationData{ File: finalFileName, diff --git a/pkg/helper.go b/pkg/helper.go index 95aab41..558c795 100644 --- a/pkg/helper.go +++ b/pkg/helper.go @@ -39,7 +39,7 @@ func moveToBackup(backupFileName string, destinationPath string) { fmt.Println("Error deleting file:", err) } - utils.Done("Database has been backed up and copied to %s", filepath.Join(destinationPath, backupFileName)) + utils.Info("Database has been backed up and copied to %s", filepath.Join(destinationPath, backupFileName)) } func deleteOldBackup(retentionDays int) { utils.Info("Deleting old backups...") @@ -54,7 +54,7 @@ func deleteOldBackup(retentionDays int) { if err != nil { utils.Fatal(fmt.Sprintf("Error: %s", err)) } else { - utils.Done("File %s has been deleted successfully", filePath) + utils.Info("File %s has been deleted successfully", filePath) } return err } @@ -81,7 +81,7 @@ func deleteOldBackup(retentionDays int) { utils.Fatal(fmt.Sprintf("Error: %s", err)) return } - utils.Done("Deleting old backups...done") + utils.Info("Deleting old backups...done") } func deleteTemp() { diff --git a/pkg/restore.go b/pkg/restore.go index e4ed9f4..91caf69 100644 --- a/pkg/restore.go +++ b/pkg/restore.go @@ -125,7 +125,7 @@ func RestoreDatabase(db *dbConfig, conf *RestoreConfig) { utils.Fatal("Error, in restoring the database %v", err) } utils.Info("Restoring database... done") - utils.Done("Database has been restored") + utils.Info("Database has been restored") //Delete temp deleteTemp() @@ -137,7 +137,7 @@ func RestoreDatabase(db *dbConfig, conf *RestoreConfig) { utils.Fatal("Error in restoring the database %v", err) } utils.Info("Restoring database... done") - utils.Done("Database has been restored") + utils.Info("Database has been restored") //Delete temp deleteTemp() } else { diff --git a/pkg/s3.go b/pkg/s3.go index 00612dd..53f597f 100644 --- a/pkg/s3.go +++ b/pkg/s3.go @@ -106,6 +106,8 @@ func DownloadFile(destinationPath, key, bucket, prefix string) error { return nil } func DeleteOldBackup(bucket, prefix string, retention int) error { + utils.Info("Deleting old backups...") + utils.Info("Bucket %s Prefix: %s Retention: %d", bucket, prefix, retention) sess, err := CreateSession() if err != nil { return err @@ -113,7 +115,7 @@ func DeleteOldBackup(bucket, prefix string, retention int) error { svc := s3.New(sess) - // Get the current time and the time threshold for 7 days ago + // Get the current time now := time.Now() backupRetentionDays := now.AddDate(0, 0, -retention) @@ -125,6 +127,7 @@ func DeleteOldBackup(bucket, prefix string, retention int) error { err = svc.ListObjectsV2Pages(listObjectsInput, func(page *s3.ListObjectsV2Output, lastPage bool) bool { for _, object := range page.Contents { if object.LastModified.Before(backupRetentionDays) { + utils.Info("Deleting old backup: %s", *object.Key) // Object is older than retention days, delete it _, err := svc.DeleteObject(&s3.DeleteObjectInput{ Bucket: aws.String(bucket), @@ -133,7 +136,7 @@ func DeleteOldBackup(bucket, prefix string, retention int) error { if err != nil { utils.Info("Failed to delete object %s: %v", *object.Key, err) } else { - utils.Info("Deleted object %s\n", *object.Key) + utils.Info("Deleted object %s", *object.Key) } } } @@ -143,6 +146,6 @@ func DeleteOldBackup(bucket, prefix string, retention int) error { utils.Error("Failed to list objects: %v", err) } - utils.Info("Finished deleting old files.") + utils.Info("Deleting old backups...done") return nil } diff --git a/utils/logger.go b/utils/logger.go index a11b13b..9000976 100644 --- a/utils/logger.go +++ b/utils/logger.go @@ -41,15 +41,6 @@ func Error(msg string, args ...any) { fmt.Printf("%s ERROR: %s\n", currentTime, formattedMessage) } } -func Done(msg string, args ...any) { - var currentTime = time.Now().Format("2006/01/02 15:04:05") - formattedMessage := fmt.Sprintf(msg, args...) - if len(args) == 0 { - fmt.Printf("%s INFO: %s\n", currentTime, msg) - } else { - fmt.Printf("%s INFO: %s\n", currentTime, formattedMessage) - } -} // Fatal logs an error message and exits the program func Fatal(msg string, args ...any) {